Re: [PATCH 1/1] tools/tracing/rtla: fix missing unistd include
From: Tomas Glozar <tglozar@redhat.com>
Date: 2026-06-23 13:12:44
Also in:
lkml
Hi Andreas, Please note that rtla uses "tools/rtla:" or "rtla:" prefix for patches, not "tools/tracing/rtla". ne 14. 6. 2026 v 11:35 odesílatel Andreas Ziegler [off-list ref] napsal:
Compiling RTLA 7.1-rc6 with GCC 16 and uClibc as standard library fails with these errors: ... Restore the missing unistd.h include.
Thanks for the fix, I missed that. Indeed, according to POSIX, alarm() has to include unistd.h. I'll try to add the uclibc build to my tests.
Fixes: <115b06a00875> (tools/rtla: Consolidate nr_cpus usage across all tools)
The conventional syntax for Fixes is:
Fixes: 115b06a00875 ("tools/rtla: Consolidate nr_cpus usage across all tools")
i.e. no angle brackets, and double quotes around the commit name. See:
https://docs.kernel.org/process/submitting-patches.html#describe-changes
quoted hunk ↗ jump to hunk
Signed-off-by: Andreas Ziegler <redacted> --- tools/tracing/rtla/src/common.c | 1 + 1 file changed, 1 insertion(+)diff --git a/tools/tracing/rtla/src/common.c b/tools/tracing/rtla/src/common.c index 35e3d3aa922e..5c5398d20f40 100644 --- a/tools/tracing/rtla/src/common.c +++ b/tools/tracing/rtla/src/common.c@@ -5,6 +5,7 @@ #include <signal.h> #include <stdlib.h> #include <string.h> +#include <unistd.h> #include <getopt.h>
The getopt.h include was removed in master, causing a conflict when applying the patch. Could you please rebase?
#include <sys/sysinfo.h> -- 2.53.0
Thanks, Tomas