Re: [PATCH 1/2] tracing: Move non-trace_printk prototypes back to kernel.h

On June 21, 2026 2:08:37 PM GMT+01:00, Yury Norov [off-list ref] wrote:

On Sun, Jun 21, 2026 at 05:34:31AM -0400, Steven Rostedt wrote:

quoted

From: Steven Rostedt <rostedt@goodmis.org>

In order to remove the include to trace_printk.h from kernel.h the tracing
control prototypes need to be moved back into kernel.h. That's because

Please don't. Instead, you can split them out to trace_control.h, and
include where needed. I actually have a prototype for it, FYI:

https://github.com/norov/linux/tree/trace_pritk3

Sure, I have no problem adding another header for this.

quoted

they are used in other common header files like rcu.h. There's no point in
removing trace_printk.h from kernel.h if it just gets added back to other
common headers.

Prototypes are very cheap for the compiler and should not be an issue.

It's not about cost, it's about mess. kernel.h is included everywhere.
Is that API needed everywhere? No, it's needed in literally 10 files.
So, no place in kernel.h.

Well one of those files is rcu.h which is also pretty much included everywhere. But OK.

-- Steve 

quoted

2.53.0