Re: [PATCHv5 bpf-next 06/28] bpf: Move trampoline image setup into bpf_trampoline_ops callbacks
From: Jiri Olsa <hidden>
Date: 2026-05-25 20:05:52
Also in:
bpf
From: Jiri Olsa <hidden>
Date: 2026-05-25 20:05:52
Also in:
bpf
On Tue, Apr 21, 2026 at 10:55:19AM +0200, Jiri Olsa wrote:
On Fri, Apr 17, 2026 at 08:10:25PM +0000, bot+bpf-ci@kernel.org wrote:quoted
quoted
There's slight functional change for the unregister path, where we currently free the image unconditionally even if the detach fails. The new code keeps the image in place, possibly preventing the crash.This appears to be fixing a bug where the image was freed even when detach failed. The bug was introduced in commit e21aa341785c ("bpf: Fix fexit trampoline.") which unconditionally freed the trampoline image.
actually the paragraph above is not accurate, we'd not prevent the crash with this change.. that needs separate fix jirka
quoted
Should this commit include a Fixes tag? The suggested tag would be: Fixes: e21aa341785c ("bpf: Fix fexit trampoline.")right, I think I'll send separate fix for current code, to have this fixed earlier jirkaquoted
--- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24583317711