Thread (36 messages) 36 messages, 6 authors, 3d ago

Re: [PATCHv3 02/12] uprobes/x86: Remove struct uprobe_trampoline object

From: Jiri Olsa <hidden>
Date: 2026-05-24 22:13:12
Also in: bpf

On Thu, May 21, 2026 at 01:26:09PM +0000, bot+bpf-ci@kernel.org wrote:
quoted
commit 35d93b034b144060a547b507cfb4268692c328c2
Author: Jiri Olsa [off-list ref]
Date:   Thu May 21 14:44:01 2026 +0200

    uprobes/x86: Remove struct uprobe_trampoline object

    Removing struct uprobe_trampoline object and it's tracking code,
    because it's not needed. We can do same thing directly on top of
    struct vm_area_struct objects.

    This makes the code simpler and allows easy propagation of the
    trampoline vma object into child process in following change.

    Note the original code called destroy_uprobe_trampoline if the
    optimiation failed, but it only freed the struct uprobe_trampoline
    object, not the vma.

    Signed-off-by: Jiri Olsa [off-list ref]
This looks like a bug fix for a VMA resource leak. The commit message
notes that when uprobe optimization failed, the original code only freed
the struct uprobe_trampoline object but leaked the VMA created by
_install_special_mapping. Should this include:

  Fixes: ba2bfc97b462 ("uprobes/x86: Add support to optimize uprobes")
no, the logic stays, we just removed one layer.. but we need separate
fix for the possible vma leak, will include it in the next version

jirka
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help