Thread (33 messages) flat view 33 messages, 2 authors, 2026-05-28

Re: [PATCH v2 01/14] tools/rv: Fix substring match bug in monitor name search

From: Nam Cao <hidden>
Date: 2026-05-18 08:13:50
Also in: lkml

Gabriele Monaco [off-list ref] writes:
 static int __ikm_find_monitor_name(char *monitor_name, char *out_name)
 {
-	char *available_monitors, container[MAX_DA_NAME_LEN+1], *cursor, *end;
-	int retval = 1;
+	char *available_monitors, *cursor, *line;
+	int len = strlen(monitor_name);
+	int found = 0;
 
 	available_monitors = tracefs_instance_file_read(NULL, "rv/available_monitors", NULL);
 	if (!available_monitors)
 		return -1;
 
-	cursor = strstr(available_monitors, monitor_name);
-	if (!cursor) {
-		retval = 0;
-		goto out_free;
-	}
+	config_is_container = 0;
Isn't config_is_container unused?

Perhaps it is used in a follow-up patch? Let me keep reading..

Nam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help