Re: [PATCH 15/61] trace: Prefer IS_ERR_OR_NULL over manual NULL check

Hi Steven,

On Wed, 11 Mar 2026 at 15:03, Steven Rostedt [off-list ref] wrote:

On Wed, 11 Mar 2026 14:13:32 +0900
Masami Hiramatsu (Google) [off-list ref] wrote:

quoted

Hmm, now IS_ERR_OR_NULL() is an inline function, so it is safe.
But if you want to use IS_ERR_OR_NULL() here, it will be better something like

node = rhashtable_walk_next(&iter);
while (!IS_ERR_OR_NULL(node)) {
      fprobe_remove_node_in_module(mod, node, &alist);
      node = rhashtable_walk_next(&iter);
}

But now you need to have a duplicate code in order to acquire "node"

I think the patch just makes the code worse.

Obviously we need a new for_each_*() helper hiding all the gory internals?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds