Re: [RFC bpf-next 12/12] selftests/bpf: Add tracing multi benchmark test
flat view
From: bot+bpf-ci@kernel.org
Date: 2026-02-03 10:13:57
Also in:
bpf
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/bpf/prog_tests/tracing_multi.c b/tools/testing/selftests/bpf/prog_tests/tracing_multi.c index 3ccf0d4ed..575454e31 100644 --- a/tools/testing/selftests/bpf/prog_tests/tracing_multi.c +++ b/tools/testing/selftests/bpf/prog_tests/tracing_multi.c@@ -6,6 +6,9 @@ #include <bpf/btf.h> #include <linux/btf.h> #include <search.h> +#include <bpf/btf.h> +#include <linux/btf.h> +#include <search.h>
These three includes are duplicates of the lines immediately above them. Were they added by mistake? [ ... ]
quoted hunk ↗ jump to hunk
+ t = btf__type_by_id(btf, proto->type); + while (t && btf_type_is_modifier(t)) + t = btf__type_by_id(btf, t->type);
The while line uses spaces for indentation instead of a tab. --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21625440628 AI-authorship-score: low AI-authorship-explanation: The commit shows characteristics typical of human-written code including copy-paste errors (duplicate includes), inconsistent whitespace, informal commit message language, and practical iterative testing with real measured results. issues-found: 2 issue-severity-score: low issue-severity-explanation: Both issues are minor code quality problems in test code: duplicate header includes and inconsistent whitespace (spaces vs tabs).