Re: [RFC PATCH 1/2] rcu: Add rcu_read_lock_notrace()
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: 2026-01-06 18:43:51
Also in:
bpf, linux-rt-devel, rcu
On 2026-01-06 13:30, Paul E. McKenney wrote:
On Tue, Jan 06, 2026 at 10:08:44AM -0500, Mathieu Desnoyers wrote:
[...]
quoted
Re-reading the comment and your explanation, I think the comments are clear enough. One nit I found while reading though: include/linux/srcutree.h: * Note that both this_cpu_inc() and atomic_long_inc() are RCU read-side * critical sections either because they disables interrupts, because disables -> disableLike this?
Looks good ! Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Thanks, Mathieu
quoted hunk ↗ jump to hunk
Thanx, Paul ------------------------------------------------------------------------ commit b3fc7ac622a19fcf921871be097e3536847406cd Author: Paul E. McKenney [off-list ref] Date: Tue Jan 6 10:28:10 2026 -0800 srcu: Fix s/they disables/they disable/ typo in srcu_read_unlock_fast() Typo fix in srcu_read_unlock_fast() header comment. Reported-by: Mathieu Desnoyers [off-list ref] Signed-off-by: Paul E. McKenney [off-list ref]diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h index d6f978b50472d..727719a3cbeb9 100644 --- a/include/linux/srcutree.h +++ b/include/linux/srcutree.h@@ -259,7 +259,7 @@ static inline struct srcu_ctr __percpu *__srcu_ctr_to_ptr(struct srcu_struct *ss * srcu_read_unlock_fast(). * * Note that both this_cpu_inc() and atomic_long_inc() are RCU read-side - * critical sections either because they disables interrupts, because + * critical sections either because they disable interrupts, because * they are a single instruction, or because they are read-modify-write * atomic operations, depending on the whims of the architecture. * This matters because the SRCU-fast grace-period mechanism uses either
-- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com