Re: [PATCH v13 2/3] mm: Fix OOM killer inaccuracy on large many-core systems
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: 2026-01-12 18:46:46
Also in:
linux-mm, lkml
On 2026-01-12 12:29, Shakeel Butt wrote:
On Sun, Jan 11, 2026 at 02:49:57PM -0500, Mathieu Desnoyers wrote: [...]quoted
@@ -626,14 +631,12 @@ static void check_mm(struct mm_struct *mm) "Please make sure 'struct resident_page_types[]' is updated as well"); for (i = 0; i < NR_MM_COUNTERS; i++) { - long x = percpu_counter_sum(&mm->rss_stat[i]); - - if (unlikely(x)) { - pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%ld Comm:%s Pid:%d\n", - mm, resident_page_types[i], x, + if (unlikely(percpu_counter_tree_precise_compare_value(&mm->rss_stat[i], 0) != 0)) + pr_alert("BUG: Bad rss-counter state mm:%p type:%s val:%d Comm:%s Pid:%d\n", + mm, resident_page_types[i], + percpu_counter_tree_precise_sum(&mm->rss_stat[i]),I haven't gone through the whole series yet but this "val:%ld" to "val:%d" conversion seems like unintended. Next patch fixed it but it should be fixed here.
My mistake, will fix for v14. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com