Thread (1 message) 1 message, 1 author, 2026-01-12

Re: [PATCH v12 0/3] mm: Fix OOM killer inaccuracy on large many-core systems

From: Roman Gushchin <roman.gushchin@linux.dev>
Date: 2026-01-12 17:16:04
Also in: linux-mm, lkml

Mathieu Desnoyers [off-list ref] writes:
On 2026-01-11 12:48, Andrew Morton wrote:
quoted
On Sun, 11 Jan 2026 10:02:46 -0500 Mathieu Desnoyers [off-list ref] wrote:
quoted
Notable changes for v12:

- Reduce per-CPU counters memory allocation size to sizeof long
   (fixing mixup with sizeof intermediate cache line aligned items).
- Use "long" counters types rather than "int".
- get_mm_counter_sum() returns a precise sum.
- Introduce and use functions to calculate the min/max possible precise
   sum values associated with an approximate sum.
May I ask, as an early adopter, what is your overall impression of
the Gemini reviewbot?
The review comments were all spot-on. This is the level of review I
would expect from a good reviewer who spends a significant amount of
effort digging into the proposed change to make sure the type limits
are OK for the intended purpose stated in the commit message and that
the intent stated in comments match the code.

As a patch author, I find this feedback really useful. Is there
an easy way to get this feedback privately before sending out my
patches ?
If you need to review a limited number of patches, the easiest way to
use gemini cli/claude code or similar tools with a consumer grade
subscription (most are $20/month these days).
I maintain a pre-configured environment for Gemini:
git@github.com:rgushchin/kengp.git , but it's not hard to hack something
similar for other tools.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help