Re: [PATCH v3 01/13] rv: Unify DA event handling functions across monitor types
From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2025-12-22 14:45:42
Also in:
lkml
From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2025-12-22 14:45:42
Also in:
lkml
On Thu, 2025-12-18 at 08:04 +0700, Nam Cao wrote:
I think this overexplains. I would just explain the "WHY", then the general idea how the patch solves the problem. Let the diff speaks for the rest. Perhaps something like: The DA event handling functions are mostly duplicated for differerent monitor types, because per-task monitors' functions require a task_struct parameter while the others do not. Unify the functions, handle the difference by always passing a da_id_type which is the task's pid for per-task monitor but is ignored for the other types.
Good point, I'll squeeze it. Thanks, Gabriele
Regardless: Reviewed-by: Nam Cao <redacted> Nam