Thread (24 messages) flat view 24 messages, 6 authors, 2025-12-21

Re: [PATCH 1/3] mm/khugepaged: remove unnecessary goto 'skip' label

From: "David Hildenbrand (Red Hat)" <david@kernel.org>
Date: 2025-12-18 09:14:16
Also in: linux-mm, lkml

On 12/16/25 12:11, Shivank Garg wrote:
quoted hunk ↗ jump to hunk
Replace 'goto skip' with actual logic for better code readability.

No functional change.

Signed-off-by: Shivank Garg <redacted>
---
  mm/khugepaged.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 6c8c35d3e0c9..107146f012b1 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
  			break;
  		}
  		if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORDER)) {
-skip:
  			progress++;
  			continue;
  		}
  		hstart = round_up(vma->vm_start, HPAGE_PMD_SIZE);
  		hend = round_down(vma->vm_end, HPAGE_PMD_SIZE);
-		if (khugepaged_scan.address > hend)
-			goto skip;
+		if (khugepaged_scan.address > hend) {
+			progress++;
+			continue;
+		}
  		if (khugepaged_scan.address < hstart)
  			khugepaged_scan.address = hstart;
  		VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK);
Oh yes, please

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

-- 
Cheers

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help