Thread (3 messages) 3 messages, 2 authors, 2025-12-17

Re: [PATCH v3] kallsyms: Always initialize modbuildid

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-12-17 22:26:23
Also in: bpf, lkml

On Wed, 10 Dec 2025 18:03:45 +0100
Maurice Hieronymus [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -7761,6 +7761,12 @@ ftrace_mod_address_lookup(unsigned long addr, unsigned long *size,
 		if (ret) {
 			if (modname)
 				*modname = mod_map->mod->name;
+			if (modbuildid)
+#if IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
IS_ENABLED() is for use within C code. This should simply be:

#ifdef CONFIG_STACKTRACE_BUILD_ID

-- Steve
+				*modbuildid = mod_map->mod->build_id;
+#else
+				*modbuildid = NULL;
+#endif
 			break;
 		}
 	}
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help