Thread (3 messages) 3 messages, 2 authors, 2025-12-10

Re: PATCH] tracing: Fix unused tracepoints when module uses only exported ones

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-12-10 01:26:05
Also in: lkml

On Mon, 8 Dec 2025 09:22:48 -0500
Mathieu Desnoyers [off-list ref] wrote:
On 2025-12-08 08:53, Steven Rostedt wrote:
quoted
From: Steven Rostedt <rostedt@goodmis.org>  
Missing bracket for [PATCH] in subject.
quoted
Building the KVM intel module failed to build with UT=1:  
failed -> fails (present ?)
After the patch is applied it will be in the past ;-)
quoted
no __tracepoint_strings in file: arch/x86/kvm/kvm-intel.o
make[3]: *** [/work/git/test-linux.git/scripts/Makefile.modfinal:62: arch/x86/kvm/kvm-intel.ko] Error 1

The reason is that the module only uses the tracepoints defined and
exported by the main kvm module. The tracepoint-udpate.c code fails the  
I guess you mean "tracepoint-update.c" ?
Oops
quoted
build if a tracepoint is used, but there's no tracepoints defined. But  
tracepoint
Actually, plural is fine here. Because it means one or more here.

quoted
this is acceptable in modules if the tracepoints is defined in the vmlinux  
tracepoint
Actually, it should stay plural (as it is more than one), but needs s/is/are/
quoted
proper or another module and exported.

Do not fail to build if a tracepoint is used but no tracepoints are  
tracepoint .. is
Again, plural is OK here, but the other fixes can be done.

Although I see this right after I send a pull request to Linus, but
because I'm currently at the Maintainers Summit with Linus, and I don't
need to test this to fix it, I'll set up another pull request and tell
him to take the second one.

Thanks,

-- Steve


But, because it's just a change log fix and 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help