Re: [PATCH v2 1/3] tracing: Remove unneeded event_mutex lock in event_trigger_regex_release()
From: Tom Zanussi <zanussi@kernel.org>
Date: 2025-12-03 22:38:14
Also in:
lkml
On Tue, 2025-11-25 at 16:40 -0500, Steven Rostedt wrote:
From: Steven Rostedt <rostedt@goodmis.org> In event_trigger_regex_release(), the only code is: mutex_lock(&event_mutex); if (file->f_mode & FMODE_READ) seq_release(inode, file); mutex_unlock(&event_mutex); return 0; There's nothing special about the file->f_mode or the seq_release() that requires any locking. Remove the unnecessary locks. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Looks good to me. Reviewed-by: Tom Zanussi <zanussi@kernel.org>
quoted hunk ↗ jump to hunk
--- kernel/trace/trace_events_trigger.c | 4 ---- 1 file changed, 4 deletions(-)diff --git a/kernel/trace/trace_events_trigger.cb/kernel/trace/trace_events_trigger.c index 7795af600466..e5dcfcbb2cd5 100644--- a/kernel/trace/trace_events_trigger.c +++ b/kernel/trace/trace_events_trigger.c@@ -314,13 +314,9 @@ static ssize_t event_trigger_regex_write(structfile *file, static int event_trigger_regex_release(struct inode *inode, struct file *file) { - mutex_lock(&event_mutex); - if (file->f_mode & FMODE_READ) seq_release(inode, file); - mutex_unlock(&event_mutex); - return 0; }