Thread (16 messages) 16 messages, 3 authors, 2025-12-02

Re: [PATCH v2 1/2] rv: Convert to use lock guard

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-11-25 19:56:56
Also in: lkml

On Mon, 17 Nov 2025 09:06:02 +0000
Nam Cao [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file *filp, const char __user *user
 		else
 			retval = rv_disable_monitor(mon);
 
-		if (!retval)
-			retval = count;
-
-		break;
+		if (retval)
+			return retval;
+		return count;
No biggy, but I wonder if this would look better as:

		return retval ? : count;

-- Steve
 	}
 
-	mutex_unlock(&rv_interface_lock);
 	return retval;
 }
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help