Thread (32 messages) 32 messages, 2 authors, 2025-11-13

Re: [PATCH v8 00/27] mm/ksw: Introduce KStackWatch debugging tool

From: Matthew Wilcox <willy@infradead.org>
Date: 2025-11-10 17:33:46
Also in: linux-doc, linux-mm, linux-perf-users, lkml, llvm, workflows

On Tue, Nov 11, 2025 at 12:35:55AM +0800, Jinchao Wang wrote:
Earlier this year, I debugged a stack corruption panic that revealed the
limitations of existing debugging tools. The bug persisted for 739 days
before being fixed (CVE-2025-22036), and my reproduction scenario
differed from the CVE report—highlighting how unpredictably these bugs
manifest.
Well, this demonstrates the dangers of keeping this problem siloed
within your own exfat group.  The fix made in 1bb7ff4204b6 is wrong!
It was fixed properly in 7375f22495e7 which lists its Fixes: as
Linux-2.6.12-rc2, but that's simply the beginning of git history.
It's actually been there since v2.4.6.4 where it's documented as simply:

      - some subtle fs/buffer.c race conditions (Andrew Morton, me)

As far as I can tell the changes made in 1bb7ff4204b6 should be
reverted.
Initially, I enabled KASAN, but the bug did not reproduce. Reviewing the
code in __blk_flush_plug(), I found it difficult to trace all logic
paths due to indirect function calls through function pointers.
So why is the solution here not simply to fix KASAN instead of this
giant patch series?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help