Re: [PATCH v1 2/2] tools/rtla: Remove unused optional option_index
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-10-29 11:12:52
Also in:
lkml
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-10-29 11:12:52
Also in:
lkml
čt 2. 10. 2025 v 14:36 odesílatel Costa Shulyupin [off-list ref] napsal:
The longindex argument of getopt_long() is optional and tied to the unused local variable option_index. Remove it to shorten the four longest functions and make the code neater.
Yes, this is documented in the manpage: "If longindex is not NULL, it points to a variable which is set to the index of the long option relative to longopts."
Signed-off-by: Costa Shulyupin <redacted> --- tools/tracing/rtla/src/osnoise_hist.c | 5 +---- tools/tracing/rtla/src/osnoise_top.c | 5 +---- tools/tracing/rtla/src/timerlat_hist.c | 5 +---- tools/tracing/rtla/src/timerlat_top.c | 5 +---- 4 files changed, 4 insertions(+), 16 deletions(-)
Reviewed-by: Tomas Glozar <tglozar@redhat.com> Tomas