Re: [PATCH v16 4/4] perf tools: Merge deferred user callchains

From
Steven Rostedt <rostedt@goodmis.org>
Date
2025-10-29 00:09:23
Also in
bpf, lkml
Reply to
Peter Zijlstra, 2025-10-24
On Fri, 24 Oct 2025 15:02:03 +0200
Peter Zijlstra [off-list ref] wrote:
quoted
The sample__merge_deferred_callchain() initializes both
orig_sample.deferred_callchain and the callchain. But now that it's not
being called, it can cause the below free to happen with junk as the
callchain. This needs:

		else
			orig_sample.deferred_callchain = false;  
Ah, so I saw crashes from here and just deleted both free()s and got on
with things ;-)
I just downloaded your tree again and it doesn't look like it was updated.

Just didn't want you to forget about this ;)

-- Steve
Thread (13 messages) 13 messages, 5 authors, last reply 2025-11-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help