Thread (16 messages) 16 messages, 3 authors, 2025-11-10

Re: [PATCH 3/3] rv: Add explicit lockdep context for reactors

From: Thomas Weißschuh <hidden>
Date: 2025-10-14 14:18:20
Also in: lkml

On Tue, Oct 14, 2025 at 03:45:39PM +0200, Gabriele Monaco wrote:
On Tue, 2025-10-14 at 14:51 +0200, Thomas Weißschuh wrote:
quoted
I can't follow here. lockdep can indicate problems, but it should not
introduce
problems on its own. So preventing the usage together with lockdep would be
the
proverbial head in the sand. If the tracepoints called by lockdep are an issue
then we would just not call into lockdep in the first place. lockdep
triggering
these tracepoints should not be an issue in practice. I don't see a
bulletproof
way to prevent a tracepoint handler from calling another tracepoint, except
maybe extending lockdep to also track that.
Forget about it, you're right. This leads to not using lockdep inside reactors
in the first place. We could even have notrace versions of the lockdep calls
(I'm not sure lockdep itself needs them), but that's getting horrid.
I still don't understand why the tracepoints called from lockdep are worse then
the ones called from the reactors themselves? Any solution should also apply to
those. Especially as even the simplest printk reactor runs into the same issue.
Leaving for a moment concurrency quirks aside, a monitor that is reacting should
be done for a while and can be marked as not monitoring before reacting, instead
of after.
Trace handlers triggered in the same tracepoints should, in principle, be able
to tell they are not supposed to run. This at least stands for DA monitors, but
the same idea could work on LTL as well.

Of course this gets more complicated in practice, but perhaps suspending
monitors during reaction can be enough to allow these lockdep calls without
risking infinite loops.
What would it mean to suspend a monitor? In my opinion we shouldn't sacrifice
the accuracy of the monitors or the reliability of the reactors while trying to
mitigate a theoretical problem.


Thomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help