Thread (9 messages) 9 messages, 2 authors, 2025-10-10

Re: [PATCH v1 1/5] tools/rtla: Add fatal() and replace error handling pattern

From: Costa Shulyupin <hidden>
Date: 2025-10-10 07:21:33
Also in: lkml

On Thu, 9 Oct 2025 at 00:55, Crystal Wood [off-list ref] wrote:
Looks like there was existing inconsistency with newlines... maybe have
fatal() include the newline automatically to simplify callers slightly?
We're not going to print a continuation if we're exiting.

Otherwise, for the whole series:
Reviewed-by: Crystal Wood <redacted>
fatal() belongs to the same family as debug_msg() and err_msg().
Historically, the prototype and usage of these functions is identical
to printf().
printk() was identical as well, but now it adds a missing end-of-line
automatically.
fatal(), along with debug_msg() and err_msg(),
can be upgraded too, but they should be updated together for consistency.

Thanks
Costa
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help