[PATCH v2] tracing/osnoise: Replace kmalloc + copy_from_user with memdup_user
From: Thorsten Blum <thorsten.blum@linux.dev>
Date: 2025-09-25 21:18:13
Also in:
lkml
Subsystem:
the rest, tracing, tracing os noise / latency tracers · Maintainers:
Linus Torvalds, Steven Rostedt, Masami Hiramatsu
Replace kmalloc() followed by copy_from_user() with memdup_user() to simplify and improve osnoise_cpus_write(). No functional changes intended. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- Changes in v2: - Rebase to apply to master and linux-next - Explicitly include linux/string.h - Link to v1: https://lore.kernel.org/lkml/20250905192116.554018-2-thorsten.blum@linux.dev/ (local) --- kernel/trace/trace_osnoise.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index 337bc0eb5d71..ab0575a94be1 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c@@ -24,6 +24,7 @@ #include <linux/sched/clock.h> #include <uapi/linux/sched/types.h> #include <linux/sched.h> +#include <linux/string.h> #include "trace.h" #ifdef CONFIG_X86_LOCAL_APIC
@@ -2325,12 +2326,9 @@ osnoise_cpus_write(struct file *filp, const char __user *ubuf, size_t count, if (count < 1) return 0; - buf = kmalloc(count, GFP_KERNEL); - if (!buf) - return -ENOMEM; - - if (copy_from_user(buf, ubuf, count)) - return -EFAULT; + buf = memdup_user(ubuf, count); + if (IS_ERR(buf)) + return PTR_ERR(buf); if (!zalloc_cpumask_var(&osnoise_cpumask_new, GFP_KERNEL)) return -ENOMEM;
--
2.51.0