Re: [RESEND][PATCH v15 2/4] perf: Support deferred user callchains

From
Peter Zijlstra <peterz@infradead.org>
Date
2025-09-23 10:01:48
Also in
bpf, lkml
Reply to
Steven Rostedt, 2025-09-08
On Mon, Sep 08, 2025 at 01:14:14PM -0400, Steven Rostedt wrote:
quoted hunk ↗ jump to hunk
+	/*
+	 * All accesses related to the event are within the same RCU section in
+	 * perf_event_callchain_deferred(). The RCU grace period before the
+	 * event is freed will make sure all those accesses are complete by then.
+	 */
+	rcuwait_wait_event(&event->pending_unwind_wait, !event->pending_unwind_callback, TASK_UNINTERRUPTIBLE);
You need a narrower terminal, this is again excessive. I mostly code
with my screen split in 4 columns (3 if I can't find my glasses), and
that gets me around 90 character columns.
quoted hunk ↗ jump to hunk
+	if (event->attr.defer_callchain)
+		init_task_work(&event->pending_unwind_work,
+			       perf_event_callchain_deferred);
And let me hand you a bucket of {}, I've heard they're getting expensive
over in the US due to this tariff nonsense :-)
Thread (25 messages) 25 messages, 4 authors, last reply 2025-10-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help