On Fri, 12 Sep 2025 21:13:07 -0700
Randy Dunlap [off-list ref] wrote:

On 9/12/25 3:11 AM, Jinchao Wang wrote:

quoted

+/**
+ * modify_wide_hw_breakpoint_local - update breakpoint config for local cpu
+ * @bp: the hwbp perf event for this cpu
+ * @attr: the new attribute for @bp
+ *
+ * This does not release and reserve the slot of HWBP, just reuse the current

                                                 of a HWBP; it just reuses

OK,

and preferable s/cpu/CPU/ in comments.

OK.

Thanks for review!

quoted

+ * slot on local CPU. So the users must update the other CPUs by themselves.
+ * Also, since this does not release/reserve the slot, this can not change the
+ * type to incompatible type of the HWBP.
+ * Return err if attr is invalid or the cpu fails to update debug register
+ * for new @attr.
+ */
+#ifdef CONFIG_HAVE_REINSTALL_HW_BREAKPOINT
+int modify_wide_hw_breakpoint_local(struct perf_event *bp,
+				    struct perf_event_attr *attr)
+{

-- 
~Randy

-- 
Masami Hiramatsu (Google) [off-list ref]