Re: [PATCH] rv/ltl_monitor: adapt handle_task_newtask to u64 clone_flags
From: David Hildenbrand <hidden>
Date: 2025-09-10 08:05:37
Also in:
lkml
On 04.09.25 13:36, Simon Schuster via B4 Relay wrote:
From: Simon Schuster <schuster.simon@siemens-energy.com>
Since commit edd3cb05c00a ("copy_process: pass clone_flags as u64 across
calltree") the task_newtask trace event exposes clone_flags as u64 to
its callbacks.
However, ltl_monitor was not adapted, resulting in a faulty callback.
This also resulted in an lkp build warning due to
-Wincompatible-pointer-types.
Fixes: edd3cb05c00a ("copy_process: pass clone_flags as u64 across calltree")
Reported-by: Stephen Rothwell <redacted>
Closes: https://lore.kernel.org/lkml/20250904113334.18822d43@canb.auug.org.au/ (local)
Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202509040134.bQVbm7ja-lkp@intel.com/ (local)
Signed-off-by: Simon Schuster <schuster.simon@siemens-energy.com>
---
I did further search for other in-tree users of the task_newtask
callback, but the trace macros make it a bit harder. Yet, as far as I
could see, there are none, so this patch hopefully resolves the problem
for good. The other matches all relate to "tp_btf/task_newtask", which
seems to be unaffected.
With this patch, ARCH=S390 allmodconfig -- that originally tripped the
LKP builds -- now builds without further -Wincompatible-pointer-types
warnings.
Sorry for causing this trouble, and thanks to Stephen Rothwell for
testing/reporting.
---Not a stable commit id I think, so it should be squashed into the original one. Acked-by: David Hildenbrand <redacted> -- Cheers David / dhildenb