Thread (8 messages) 8 messages, 1 author, 2025-09-10

Re: [PATCH v2 4/6] tracing: wprobe: Add wprobe event trigger

From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2025-09-10 01:22:24
Also in: linux-doc, linux-perf-users, lkml

On Fri,  5 Sep 2025 23:58:44 +0900
"Masami Hiramatsu (Google)" [off-list ref] wrote:
+static void wprobe_unregister_trigger(char *glob,
+				      struct event_trigger_data *data,
+				      struct trace_event_file *file)
+{
+	lockdep_assert_held(&event_mutex);
+
+	if (wprobe_trigger_exist_same(data, file)) {
+		list_del_rcu(&data->list);
+		trace_event_trigger_enable_disable(file, 0);
+		update_cond_flag(file);
+	}
+
+	if (data && data->ops->free)
+		data->ops->free(data);
+}
This function is wrongly free the passed trigger_data instead of
trigger_data on the event. The passed @data is a dummy data to
find the actual data from @file.
Thanks Jinchao to find it!

Thank you,

-- 
Masami Hiramatsu (Google) [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help