Re: [RFC PATCH 16/17] verification/rvgen: Add support for per-obj monitors
From: Nam Cao <hidden>
Date: 2025-09-04 08:58:08
Also in:
lkml
From: Nam Cao <hidden>
Date: 2025-09-04 08:58:08
Also in:
lkml
On Thu, Sep 04, 2025 at 10:39:31AM +0200, Gabriele Monaco wrote:
Mmh, I see what you mean. I wasn't aware of this textwrap, but what immediately comes to mind is that we'd end up mixing spaces (python indentation) and tabs (C indentation). While textwrap may handle the case, it doesn't look too readable to me. I'd say we can (slowly) transition to using textwrap here but mandate having \t for tabs to make them explicit (didn't test). What do you think?
Right, I didn't consider the mixing indentation problem. Using \t isn't much better, it is harder to see how the generated code will look. One idea is using something like clang-format (Documentation/dev-tools/clang-format.rst). It doesn't have to be done in this series of course, I'm fine leaving this be for now. Nam