Re: [PATCH v6 5/6] tracing: Show inode and device major:minor in deferred user space stacktrace
From: Steven Rostedt <rostedt@kernel.org>
Date: 2025-08-28 21:17:54
Also in:
bpf, lkml
From: Steven Rostedt <rostedt@kernel.org>
Date: 2025-08-28 21:17:54
Also in:
bpf, lkml
On Thu, 28 Aug 2025 14:06:39 -0700 Linus Torvalds [off-list ref] wrote:
So you can certainly use siphash for hashing, but make sure to not use the same secret key that the printing does.
Right, I just meant to use the same algorithm. The key would be different.
As to the ID to hash, I actually think a 'struct file *' might be the best thing to use - that's directly in the vma, no need to follow any other pointers for it.
But that's unique per task, right? What I liked about the f_inode pointer, is that it appears to be shared between tasks. I only want to add a new hash and print the path for a new file. If several tasks are using the same file (which they are with the libraries), then having the hash be the same between tasks would be more efficient. -- Steve