Re: [PATCH bpf-next v5 1/4] fprobe: use rhltable for fprobe_ip_table
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2025-08-20 02:05:18
Also in:
bpf, lkml
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2025-08-20 02:05:18
Also in:
bpf, lkml
Masami Hiramatsu , Google [off-list ref] wrote:
Good catch! Hmm, previously we guaranteed that the find_first_fprobe_node() must be called under rcu read locked or fprobe_mutex locked, so that the node list should not be changed. But according to the comment of rhltable_lookup(), we need to lock the rcu_read_lock() around that.
Just as is the case for RCU in general, rcu read locks are unnecessary for rhashtable if you already hold the write-side locks. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt