Re: [PATCHv6 perf/core 08/22] uprobes/x86: Add mapping for optimized uprobe trampolines
From: Peter Zijlstra <peterz@infradead.org>
Date: 2025-08-19 14:53:56
Also in:
bpf, lkml
On Sun, Jul 20, 2025 at 01:21:18PM +0200, Jiri Olsa wrote:
quoted hunk ↗ jump to hunk
+static void destroy_uprobe_trampoline(struct uprobe_trampoline *tramp) +{ + /* + * We do not unmap and release uprobe trampoline page itself, + * because there's no easy way to make sure none of the threads + * is still inside the trampoline. + */ + hlist_del(&tramp->node); + kfree(tramp); +}
I am somewhat confused; isn't this called from __mmput()->uprobe_clear_state()->arch_uprobe_clear_state ? At that time we don't have threads anymore and mm is about to be destroyed anyway.