Re: [PATCH v2] tools/rtla: Consolidate common parameters into shared structure
From: Costa Shulyupin <hidden>
Date: 2025-08-05 07:04:21
Also in:
bpf, lkml
From: Costa Shulyupin <hidden>
Date: 2025-08-05 07:04:21
Also in:
bpf, lkml
On Mon, 4 Aug 2025 at 21:18, Crystal Wood [off-list ref] wrote:
If you want, I could rebase that on this and use container_of() to for tool- specific params... but then that adds complexity with the top and hist- specific params, most of which are common between timerlat and osnoise (and not merged by this patch).
I’d appreciate it if you could rebase your patchset on top of this one. This patch is just the first; I’ve intentionally kept it minimal to ease integration. My goal is to refactor rtla and submit a series of follow-up patches to reduce code duplication.
So we might want to just keep it simple with one big struct.
This is a god object anti-pattern.
new common.h if we want to keep the actual-osnoise-tracer stuff separate
I agree with the new common.h and separating things out. -Costa