Thread (3 messages) 3 messages, 2 authors, 2025-07-17

Re: [PATCH net-next v6] tcp: trace retransmit failures in tcp_retransmit_skb

From: <fan.yu9@zte.com.cn>
Date: 2025-07-17 02:13:00
Also in: lkml, netdev

quoted
print fmt: "skbaddr=%p skaddr=%p family=%s sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s err=%d"

Suggested-by: KuniyukiIwashima <kuniyu@google.com>
I don't deserve this tag.  (Also, a space between first/last name is missing.)

Suggested-by can be used when the core idea is provided by someone,
but not when someone just reviews the patch and points out something
wrong.

But code-wise, the change looks good to me.

Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Hi Kuniyuki,

Thank you for your thorough review and guidance - it's greatly appreciated.
I'll submit v7 with corrected tags :).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help