Re: [PATCH v3 10/17] rv: Fix generated files going over 100 column limit
From: Nam Cao <hidden>
Date: 2025-07-15 15:08:31
Also in:
lkml
On Tue, Jul 15, 2025 at 09:14:27AM +0200, Gabriele Monaco wrote:
quoted hunk ↗ jump to hunk
The dot2c.py script generates all states in a single line. This breaks the 100 column limit when the state machines are non-trivial. Recent changes allow it to print states over multiple lines if the resulting line would have been too long. Adapt existing monitors with line length over the limit. Signed-off-by: Gabriele Monaco <gmonaco@redhat.com> --- kernel/trace/rv/monitors/sco/sco.h | 12 ++++++++++-- kernel/trace/rv/monitors/snep/snep.h | 14 ++++++++++++-- kernel/trace/rv/monitors/snroc/snroc.h | 12 ++++++++++-- 3 files changed, 32 insertions(+), 6 deletions(-)diff --git a/kernel/trace/rv/monitors/sco/sco.h b/kernel/trace/rv/monitors/sco/sco.h index 7a4c1f2d5ca1c..83ca9a03331af 100644 --- a/kernel/trace/rv/monitors/sco/sco.h +++ b/kernel/trace/rv/monitors/sco/sco.h@@ -39,8 +39,16 @@ static const struct automaton_sco automaton_sco = { "schedule_exit" }, .function = { - { thread_context_sco, scheduling_context_sco, INVALID_STATE }, - { INVALID_STATE, INVALID_STATE, thread_context_sco }, + { + thread_context_sco, + scheduling_context_sco, + INVALID_STATE + }, + { + INVALID_STATE, + INVALID_STATE, + thread_context_sco + },
I'm confused, these lines were not over 100 columns. Same for snroc. From my understanding of the previous patch, the script does not break lines which are not over the limit. Did I miss something? Nam