Re: [PATCH v12 02/12] printk: Make vprintk_deferred() public
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-07-09 18:49:18
Also in:
lkml
On Wed, 9 Jul 2025 19:56:19 +0200 Nam Cao [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/printk.h b/include/linux/printk.h index 5b462029d03c..d886ec98fbbd 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h@@ -154,6 +154,7 @@ int vprintk_emit(int facility, int level, asmlinkage __printf(1, 0) int vprintk(const char *fmt, va_list args); +__printf(1, 0) int vprintk_deferred(const char *fmt, va_list args); asmlinkage __printf(1, 2) __cold int _printk(const char *fmt, ...);@@ -214,6 +215,10 @@ int vprintk(const char *s, va_list args) { return 0; } +static inline __printf(1, 0) int vprintk_deferred(const char *fmt, va_list args) +{ + return 0; +} static inline __printf(1, 2) __cold int _printk(const char *s, ...) {
All use cases I've seen throughout the kernel has the __printf() macro
on the line before the function. You're introducing a new formatting.
I'm thinking we should stay consistent:
__printf(1, 0)
int vprintk_deferred(const char *fmt, va_list args);
static inline __printf(1, 0)
int vprintk_deferred(const char *fmt, va_list args)
{
return 0;
}
-- Steve