On 6/19/2025 12:43 AM, Chao Gao wrote:

quoted

Suggested-by: Sean Christopherson <seanjc@google.com>
Co-developed-by: Xin Li (Intel) <xin@zytor.com>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
Signed-off-by: Sohil Mehta <redacted>

Reviewed-by: Chao Gao <redacted>

Thanks!

One nit below,

quoted

--- a/arch/x86/kernel/apic/local.h
+++ b/arch/x86/kernel/apic/local.h

@@ -24,22 +24,24 @@ extern u32 x2apic_max_apicid;

/* IPI */

+u16 __prepare_ICR_DM_vector(u16 vector);
+

This seems unnecessary. local.h already includes asm/apic.h, where the function
is defined.

I added this because 0day was flagging an issue with i386 allnoconfig.
But, thinking about it more, I'll instead move the definition of
__prepare_ICR_DM_vector() outside the CONFIG_X86_LOCAL_APIC section in
asm/apic.h.