Re: [PATCH v2 00/13] xfs: tracing: remove unused event xfs_reflink_cow_found
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2025-06-16 19:18:53
Also in:
linux-xfs, lkml
Bah, I hate the multiple clipboards of the Linux desktop. I had cut and pasted the above subject line in one clipboard and then cut the subject I wanted in another, and unfortunately pasted the former :-p This is what the subject was supposed to be: "xfs: remove unused trace events" On Mon, 16 Jun 2025 13:51:46 -0400 Steven Rostedt [off-list ref] wrote:
Trace events take up to 5K in memory for text and meta data. I have code that will trigger a warning when it detects unused tracepoints[1]. The XFS file system contains many events that are not called. Most of them used to be called but due to code refactoring the calls were removed but the trace events stayed behind. Some events were added but never used. If they were recent, I just reported them, but if they were older, this series simply removes them. One is called only when CONFIG_COMPACT is defined, so an #ifdef was placed around it. Finally, one event is supposed to be a trace event class, but was created with the TRACE_EVENT() macro and not the DECLARE_EVENT_CLASS() macro. This works because a TRACE_EVENT() is simply a DECLARE_EVENT_CLASS() and DEFINE_EVENT() where the class and event have the same name. But as this was a mistake, the event created should not exist. [1] https://patchwork.kernel.org/project/linux-trace-kernel/cover/20250612235827.011358765@goodmis.org/ Changes since v1: https://lore.kernel.org/linux-trace-kernel/20250612212405.877692069@goodmis.org/ (local)
And this should have been to the lore link and not patchwork: https://lore.kernel.org/linux-trace-kernel/20250612235827.011358765@goodmis.org/ (local) -- Steve