Re: [PATCH v6 3/9] x86/nmi: Extend the registration interface to include the NMI-source vector
From: Dave Hansen <hidden>
Date: 2025-06-03 17:07:51
Also in:
kvm, linux-edac, linux-perf-users, linux-pm, lkml
On 5/13/25 13:37, Sohil Mehta wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c@@ -242,13 +242,13 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev) /* * Only one function can register for NMI_UNKNOWN */ - retval = register_nmi_handler(NMI_UNKNOWN, hpwdt_pretimeout, 0, "hpwdt"); + retval = register_nmi_handler(NMI_UNKNOWN, hpwdt_pretimeout, 0, "hpwdt", 0); if (retval) goto error; - retval = register_nmi_handler(NMI_SERR, hpwdt_pretimeout, 0, "hpwdt"); + retval = register_nmi_handler(NMI_SERR, hpwdt_pretimeout, 0, "hpwdt", 0); if (retval) goto error1; - retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt"); + retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt", 0); if (retval)
Could we get rid of all these random 0's, please? (or at least try to keep them from proliferating). Either do a: register_nmi_handler_source() that takes a source and leave register_nmi_handler() in place and not take a source. Or, do this: retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt", NMI_NO_SOURCE); where the 0 is at least given a symbolic name.