Re: [PATCH 0/2] nfsd: use threads array as-is in netlink thread set interface

On 5/28/25 2:22 PM, Jeff Layton wrote:

On Wed, 2025-05-28 at 14:11 -0400, cel@kernel.org wrote:

quoted

From: Chuck Lever <redacted>

On Tue, 27 May 2025 20:12:46 -0400, Jeff Layton wrote:

quoted

The first patch is probably appropriate for stable. It should fix
problems when someone sets the pool_mode to pernode, without userland
sending down a fully-populated thread array.

The second patch just adds a couple of new tracepoints that I ended up
using to track this down.

[...]

Applied to nfsd-testing, thanks!

[1/2] nfsd: use threads array as-is in netlink interface
      commit: b2a9a114a3c7f5abfa2875b70ce9b73525a74291
[2/2] sunrpc: new tracepoints around svc thread wakeups
      commit: 65b8babe551bddf00aac69bc905f88a4e0371766

My apologies, Chuck. Patch #2 has a bug in it:

+       trace_svc_pool_thread_noidle(pool, rqstp->rq_task->pid);

In the call above, the rqstp will be undefined. That should be:

+       trace_svc_pool_thread_noidle(pool, 0);

You can fix that up in tree, or I can resend if you prefer.

Fixed.


-- 
Chuck Lever