Thread (11 messages) 11 messages, 4 authors, 2025-05-29

Re: [PATCH] mm: remove unused mmap tracepoints

From: Lorenzo Stoakes <hidden>
Date: 2025-05-28 15:23:52
Also in: linux-mm, lkml

Sorry this wasn't picked up.

Andrew - one to pick up after merge window? :)

Caleb - I'd ping again after the merge window is over if it's not picked up
this week. This isn't a great time as people tend to be busy sending stuff
over to Linus.

On Wed, May 28, 2025 at 08:16:24AM -0700, Caleb Sander Mateos wrote:
Hi MM folks,
Would you mind picking up this patch to remove some old tracepoints?
Liam has already given it a review.
I am actually curious about reintroducing these at some point, but no harm
removing them for now as they are as you say, unused. If I do work on
reintroducing them I can obviously... reintroduce them :)
Thanks,
Caleb

On Fri, Apr 11, 2025 at 10:23 AM Liam R. Howlett
[off-list ref] wrote:
quoted
* Caleb Sander Mateos [off-list ref] [250411 12:18]:
quoted
The vma_mas_szero and vma_store tracepoints are unused since commit
fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator").
Remove them so they are no longer listed as available tracepoints.
Thanks for doing this.

Reviewed-by: Liam R. Howlett <redacted>
LGTM so:

Reviewed-by: Lorenzo Stoakes <redacted>
quoted
quoted
Reported-by: Eric Mueller <redacted>
Signed-off-by: Caleb Sander Mateos <redacted>
---
 include/trace/events/mmap.h | 52 -------------------------------------
 1 file changed, 52 deletions(-)
diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
index f8d61485de16..ee2843a5daef 100644
--- a/include/trace/events/mmap.h
+++ b/include/trace/events/mmap.h
@@ -41,62 +41,10 @@ TRACE_EVENT(vm_unmapped_area,
              __entry->total_vm, __entry->flags, __entry->length,
              __entry->low_limit, __entry->high_limit, __entry->align_mask,
              __entry->align_offset)
 );

-TRACE_EVENT(vma_mas_szero,
-     TP_PROTO(struct maple_tree *mt, unsigned long start,
-              unsigned long end),
-
-     TP_ARGS(mt, start, end),
-
-     TP_STRUCT__entry(
-                     __field(struct maple_tree *, mt)
-                     __field(unsigned long, start)
-                     __field(unsigned long, end)
-     ),
-
-     TP_fast_assign(
-                     __entry->mt             = mt;
-                     __entry->start          = start;
-                     __entry->end            = end;
-     ),
-
-     TP_printk("mt_mod %p, (NULL), SNULL, %lu, %lu,",
-               __entry->mt,
-               (unsigned long) __entry->start,
-               (unsigned long) __entry->end
-     )
-);
-
-TRACE_EVENT(vma_store,
-     TP_PROTO(struct maple_tree *mt, struct vm_area_struct *vma),
-
-     TP_ARGS(mt, vma),
-
-     TP_STRUCT__entry(
-                     __field(struct maple_tree *, mt)
-                     __field(struct vm_area_struct *, vma)
-                     __field(unsigned long, vm_start)
-                     __field(unsigned long, vm_end)
-     ),
-
-     TP_fast_assign(
-                     __entry->mt             = mt;
-                     __entry->vma            = vma;
-                     __entry->vm_start       = vma->vm_start;
-                     __entry->vm_end         = vma->vm_end - 1;
-     ),
-
-     TP_printk("mt_mod %p, (%p), STORE, %lu, %lu,",
-               __entry->mt, __entry->vma,
-               (unsigned long) __entry->vm_start,
-               (unsigned long) __entry->vm_end
-     )
-);
-
-
 TRACE_EVENT(exit_mmap,
      TP_PROTO(struct mm_struct *mm),

      TP_ARGS(mm),

--
2.45.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help