Re: [PATCH 6/6] x86/vdso: Enable sframe generation in VDSO
From: Jens Remus <hidden>
Date: 2025-05-27 14:17:35
Also in:
lkml
On 25.04.2025 04:37, Steven Rostedt wrote:
From: Josh Poimboeuf <jpoimboe@kernel.org> Enable sframe generation in the VDSO library so kernel and user space can unwind through it. Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- Changes since v5: https://lore.kernel.org/20250422183722.919601983@goodmis.org (local) - Replace $(comma) with a comma in the Makefile (Jens Remus)
quoted hunk ↗ jump to hunk
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
quoted hunk ↗ jump to hunk
@@ -47,13 +47,17 @@ quiet_cmd_vdso2c = VDSO2C $@ $(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE $(call if_changed,vdso2c) +ifeq ($(CONFIG_AS_SFRAME),y) + SFRAME_CFLAGS := -Wa,-gsframe
Nit: The GNU assembler (GAS) option as of "as --help" and "man as" is "--gsframe" (with two dashes). But as GAS uses getopt_long_only() it accepts long options prefixed with "--" as well as "-". I don't have any preference.
+endif +
Regards, Jens -- Jens Remus Linux on Z Development (D3303) +49-7031-16-1128 Office jremus@de.ibm.com IBM IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294 IBM Data Privacy Statement: https://www.ibm.com/privacy/