Re: [PATCH v2] scsi: trace: change the rtn log in string

On Wed, 14 May 2025 15:44:56 +0800
Kassey Li [off-list ref] wrote:

In default it showed rtn in decimal.

kworker/3:1H-183 [003] ....  51.035474: scsi_dispatch_cmd_error: host_no=0 channel=0 id=0 lun=4 data_sgl=1  prot_sgl=0 prot_op=SCSI_PROT_NORMAL cmnd=(READ_10 lba=3907214  txlen=1 protect=0 raw=28 00 00 3b 9e 8e 00 00 01 00) rtn=4181

In source code we define these possible value as hexadecimal:

include/scsi/scsi.h

SCSI_MLQUEUE_HOST_BUSY   0x1055
SCSI_MLQUEUE_DEVICE_BUSY 0x1056
SCSI_MLQUEUE_EH_RETRY    0x1057
SCSI_MLQUEUE_TARGET_BUSY 0x1058

This change shows the string type.

Nit, but would an example of the new output be useful in the change log?

Signed-off-by: Kassey Li <redacted>

Other than that,

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve