Re: [PATCH] scsi: trace: change the rtn log in hex format

On 2025/5/13 0:11, Steven Rostedt wrote:

On Fri, 9 May 2025 13:38:40 +0800
Kassey Li [off-list ref] wrote:

quoted

In default it showed rtn in decimal.

kworker/3:1H-183 [003] ....  51.035474: scsi_dispatch_cmd_error: host_no=0 channel=0 id=0 lun=4 data_sgl=1  prot_sgl=0 prot_op=SCSI_PROT_NORMAL cmnd=(READ_10 lba=3907214  txlen=1 protect=0 raw=28 00 00 3b 9e 8e 00 00 01 00) rtn=4181

In source code we define these possible value as hexadecimal:

include/scsi/scsi.h

SCSI_MLQUEUE_HOST_BUSY   0x1055
SCSI_MLQUEUE_DEVICE_BUSY 0x1056
SCSI_MLQUEUE_EH_RETRY    0x1057
SCSI_MLQUEUE_TARGET_BUSY 0x1058

Hmm, would you want to make this show text?

   agree, will send v2 as your suggest.

quoted

This change converts the rtn in hexadecimal.

Signed-off-by: Kassey Li <redacted>
---
  include/trace/events/scsi.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
index bf6cc98d9122..a4c089ac834c 100644
--- a/include/trace/events/scsi.h
+++ b/include/trace/events/scsi.h

@@ -240,7 +240,7 @@ TRACE_EVENT(scsi_dispatch_cmd_error,
  
  	TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u prot_sgl=%u" \
  		  " prot_op=%s driver_tag=%d scheduler_tag=%d cmnd=(%s %s raw=%s)" \
-		  " rtn=%d",
+		  " rtn=0x%x",

		  " rtn=%s",

quoted

  		  __entry->host_no, __entry->channel, __entry->id,
  		  __entry->lun, __entry->data_sglen, __entry->prot_sglen,
  		  show_prot_op_name(__entry->prot_op), __entry->driver_tag,

		__print_symbolic(rtn, { SCSI_MLQUEUE_HOST_BUSY, "HOST_BUSY" },
				      { SCSI_MLQUEUE_DEVICE_BUSY, "DEVICE_BUSY" },
				      { SCSI_MLQUEUE_EH_RETRY, "EH_RETRY" },
				      { SCSI_MLQUEUE_TARGET_BUSY, "TARGET_BUSY" })

?

-- Steve