Thread (14 messages) 14 messages, 3 authors, 2025-03-24

Re: [PATCH v1 1/6] seq_buf: Mark binary printing functions with __printf() attribute

From: Andy Shevchenko <hidden>
Date: 2025-03-24 16:08:50
Also in: linux-hardening, lkml

On Mon, Mar 24, 2025 at 6:03 PM Steven Rostedt [off-list ref] wrote:
On Thu, 20 Mar 2025 20:04:22 +0200
Andy Shevchenko [off-list ref] wrote:
quoted
Binary printing functions are using printf() type of format, and compiler
is not happy about them as is:

lib/seq_buf.c:162:17: error: function ‘seq_buf_bprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]

Fix the compilation errors by adding __printf() attribute.
Should also note the removal of "extern"
If it is worth it, why not? The idea is to make it slightly more
consistent with code around (file seems to have both approaches).

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help