On Thu, Mar 20, 2025 at 9:36 PM Feng Yang [off-list ref] wrote:

[...]

So the return of bpf_perf_event_read_value_proto can be done through the bpf_base_func_proto function.
bpf_base_func_proto
        ......
        case BPF_FUNC_perf_event_read_value:
                return bpf_get_perf_event_read_value_proto();

I think this can be removed.

I see. I misunderstood this part because I was reading code before
ae0a457f5d33c336f3c4259a258f8b537531a04b. Now it looks good.

Acked-by: Song Liu <song@kernel.org>

quoted

For future patches, please read Documentation/bpf/bpf_devel_QA.rst
and follow rules for email subject, etc. For example, this patch should
have a subject like "[PATCH bpf-next] xxx".

Thank you very much for your suggestion. I will pay attention to it next time.