Thread (6 messages) 6 messages, 2 authors, 2025-03-11

Re: [PATCH v5] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

From: Shuai Xue <xueshuai@linux.alibaba.com>
Date: 2025-03-11 02:07:00
Also in: linux-edac, linux-pci, lkml


在 2025/3/10 22:50, Steven Rostedt 写道:
On Mon, 10 Mar 2025 11:59:55 +0800
Shuai Xue [off-list ref] wrote:
quoted
Hi, Steve,

If I move PCI_HOTPLUG_EVENT into one place, `include/upai/linux/pci.h`,
I need to include:

      #include <linux/tracepoint.h>

Then, kernel build fails with CONFIG_UAPI_HEADER_TEST=y:
Just move the enum definitions, not the entire event file.

That is, have one place has the PCI_HOTPLUG_EVENT macro, and have both the
uapi header as well as the tracepoint header include that header.

I guess I need to see the entire change.
Hi, Steven,

IMHO, the problem is that the PCI_HOTPLUG_EVENT macro needs to include
"linux/tracepoint.h" but it is not allowed in userspace.

The entire change in v6 build fails with CONFIG_UAPI_HEADER_TEST=y:

   https://lore.kernel.org/lkml/202501190108.tRReJA1Z-lkp@intel.com/T/#mae507b91b8b80c386dfa9e63fbbdd45826c2e003 (local)

(sorry, I did not see the problem because my local .config do not set
CONFIG_UAPI_HEADER_TEST)

Thanks
Shuai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help