Re: [PATCH net-next] trace: tcp: Add tracepoint for tcp_sendmsg()

From
David Ahern <dsahern@kernel.org>
Date
2025-02-26 18:31:51
Also in
lkml, netdev
Reply to
Eric Dumazet, 2025-02-26
On 2/26/25 11:27 AM, Eric Dumazet wrote:
On Wed, Feb 26, 2025 at 7:18 PM Breno Leitao [off-list ref] wrote:
quoted
Hello David,

On Wed, Feb 26, 2025 at 10:12:08AM -0700, David Ahern wrote:
quoted
On 2/26/25 9:10 AM, Breno Leitao wrote:
quoted
quoted
Also, if a tracepoint is added, inside of tcp_sendmsg_locked would cover
more use cases (see kernel references to it).
Agree, this seems to provide more useful information
quoted
We have a patch for a couple years now with a tracepoint inside the
Sorry, where do you have this patch? is it downstream?
company tree. Attached. Where to put tracepoints and what arguments to
supply so that it is beneficial to multiple users is always a touchy
subject :-)
Thanks. I would like to state that this would be useful for Meta as
well.

Right now, we (Meta) are using nasty `noinline` attribute in
tcp_sendmsg() in order to make the API stable, and this tracepoint would
solve this problem avoiding the `noinline` hack. So, at least two type
of users would benefit from it.
quoted
so I have not tried to push the patch out. sock arg should
be added to it for example.
True, if it becomes a tracepoint instead of a rawtracepoint, the sock
arg might be useful.

How would you recommend me proceeding in this case?
In 2022, Menglong Dong added __fix_address

Then later , Yafang Shao  added noinline_for_tracing .

Would one of them be sufficient ?
tcp_sendmsg_locked should not be getting inlined; it is the
sendmsg_locked handler and directly called by several subsystems.

ie., moving the tracepoint to tcp_sendmsg_locked should solve the inline
problem. From there, the question is inside the loop or at entry to the
function. Inside the loop has been very helpful for me.
Thread (18 messages) 18 messages, 7 authors, last reply 2025-04-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help