Re: [PATCH 4/8] tracing: probe-events: Log errro for exceeding the number of arguments
From: Markus Elfring <hidden>
Date: 2025-02-26 16:13:43
Also in:
linux-kselftest, lkml
…
quoted hunk ↗ jump to hunk
+++ b/kernel/trace/trace_fprobe.c@@ -1201,8 +1201,11 @@ static int trace_fprobe_create_internal(int argc, const char *argv[], argc = new_argc; argv = new_argv; } - if (argc > MAX_TRACE_ARGS) + if (argc > MAX_TRACE_ARGS) { + trace_probe_log_set_index(2); + trace_probe_log_err(0, TOO_MANY_ARGS); return -E2BIG; + } ret = traceprobe_expand_dentry_args(argc, argv, &dbuf);
… May a bit of exception handling code be shared by an additional jump target? Will another goto chain become helpful here? How do you think about to avoid a typo in the summary phrase? Regards, Markus