Thread (12 messages) flat view 12 messages, 3 authors, 2025-02-20

Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()

From: Oleg Nesterov <oleg@redhat.com>
Date: 2025-02-20 12:26:13
Also in: bpf, linux-mm, linux-perf-users, lkml

On 02/20, Tong Tiangen wrote:
在 2025/2/20 16:38, David Hildenbrand 写道:
quoted
On 20.02.25 03:31, Tong Tiangen wrote:
quoted
@@ -506,6 +506,12 @@ int uprobe_write_opcode(struct arch_uprobe
*auprobe, struct mm_struct *mm,
         if (ret <= 0)
                 goto put_old;

+       if (WARN(is_zero_page(old_page),
This can likely be triggered by user space, so do not use WARN.
OK,thanks.

Hi Oleg, is that all right?
Thanks, LGTM.

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help