[PATCH v1] rtla: Save trace when option `--trace` is specified
From: Costa Shulyupin <hidden>
Date: 2025-01-27 17:03:01
Also in:
lkml
Subsystem:
real-time linux analysis (rtla) tools, the rest · Maintainers:
Steven Rostedt, Tomas Glozar, Linus Torvalds
Rtla saves trace output only when option `--auto` or `--stop` is specified. Single option `--trace` enables tracing, but doesn't save it. Save trace output in any case. Signed-off-by: Costa Shulyupin <redacted> --- tools/tracing/rtla/src/osnoise_hist.c | 9 ++++----- tools/tracing/rtla/src/osnoise_top.c | 9 ++++----- 2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src/osnoise_hist.c
index b4930b835b0a1..38fd10b2a3488 100644
--- a/tools/tracing/rtla/src/osnoise_hist.c
+++ b/tools/tracing/rtla/src/osnoise_hist.c@@ -981,12 +981,11 @@ int osnoise_hist_main(int argc, char *argv[]) return_value = 0; - if (osnoise_trace_is_off(tool, record)) { + if (osnoise_trace_is_off(tool, record)) printf("rtla osnoise hit stop tracing\n"); - if (params->trace_output) { - printf(" Saving trace to %s\n", params->trace_output); - save_trace_to_file(record->trace.inst, params->trace_output); - } + if (params->trace_output) { + printf(" Saving trace to %s\n", params->trace_output); + save_trace_to_file(record->trace.inst, params->trace_output); } out_hist:
diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/osnoise_top.c
index 4772677ac762c..0af639982b7c1 100644
--- a/tools/tracing/rtla/src/osnoise_top.c
+++ b/tools/tracing/rtla/src/osnoise_top.c@@ -811,12 +811,11 @@ int osnoise_top_main(int argc, char **argv) return_value = 0; - if (osnoise_trace_is_off(tool, record)) { + if (osnoise_trace_is_off(tool, record)) printf("osnoise hit stop tracing\n"); - if (params->trace_output) { - printf(" Saving trace to %s\n", params->trace_output); - save_trace_to_file(record->trace.inst, params->trace_output); - } + if (params->trace_output) { + printf(" Saving trace to %s\n", params->trace_output); + save_trace_to_file(record->trace.inst, params->trace_output); } out_top:
--
2.47.0