Thread (13 messages) 13 messages, 2 authors, 2025-01-09

Re: [PATCH v5 4/5] tracing/kprobes: Simplify __trace_kprobe_create() by removing gotos

From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2025-01-09 01:41:31
Also in: lkml

On Wed, 8 Jan 2025 10:11:11 -0500
Steven Rostedt [off-list ref] wrote:
On Wed,  8 Jan 2025 11:11:18 +0900
"Masami Hiramatsu (Google)" [off-list ref] wrote:
quoted
-static int __trace_kprobe_create(int argc, const char *argv[])
+static int ___trace_kprobe_create(int argc, const char *argv[],
+				  struct traceprobe_parse_context *ctx)
 {
I'm not sure I care about all the underscores. It just adds to confusion.

Maybe just:

static int __create_trace_kprobe(..)
Ok. Or __trace_kprobe_create_internal()?

Then it will be

trace_kprobe_create()
 -> __trace_kprobe_create()
   -> __trace_kprobe_create_internal()

Thanks,
?

-- Steve

-- 
Masami Hiramatsu (Google) [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help